Profile Editting Bug

AresMUSH
1

Potential bug. On .15 and also now on .16, people are unable to edit their profiles via the website.

The log shows the following:

_2018-06-20 04:55:41 ERROR - Unhandled web request: {“cmd”=>“profileEdit”, “args”=>{“id”=>“8”}, “api_key”=>“e12fc252-d870-4f4c-ae0a-ddd6c90847f7”, “auth”=>{“authenticator”=>“authenticator:ares”, “token”=>“75f16845-6d26-4684-8475-c92743ffe6c2”, “name”=>“Scarecrow”, “id”=>“8”, “is_approved”=>“true”, “is_admin”=>“true”, “is_coder”=>“true”}, “captures”=>[]}. _

2018-06-20 04:55:41 ERROR - Error in Web Request: client= error=undefined method description' for "A straw man":String backtrace=["/home/ares/aresmush/plugins/profile/web/profile_edit_request_handler.rb:66:inhandle’", “/home/ares/aresmush/engine/aresmush/commands/dispatcher.rb:125:in block (2 levels) in on_web_request'", "/home/ares/aresmush/engine/aresmush/commands/dispatcher.rb:119:ineach’”, “/home/ares/aresmush/engine/aresmush/commands/dispatcher.rb:119:in block in on_web_request'", "/home/ares/aresmush/engine/aresmush/error_block.rb:6:inwith_error_handling’”, “/home/ares/aresmush/engine/aresmush/commands/dispatcher.rb:118:in on_web_request'", "/home/ares/aresmush/engine/aresmush/web/engine_api_server.rb:77:inblock in handle_request’”, “/home/ares/aresmush/engine/aresmush/error_block.rb:6:in with_error_handling'", "/home/ares/aresmush/engine/aresmush/web/engine_api_server.rb:71:inhandle_request’”, “/home/ares/aresmush/engine/aresmush/web/engine_api_server.rb:61:in `block in '”]

2

Yeah that’s a bug related to the description overhaul - thanks for the report.

Will fix in the next patch. If it’s getting in your way before then, the fix is in aresmush/plugins/profile/web/profile_edit_request_handler on line 66. Change this line:

          shortdesc: char.shortdesc ? char.shortdesc.description : '',

to this:

           shortdesc: char.shortdesc ? char.shortdesc: '',
3

So I updated to 0.19 and now I’m unable to edit profiles via the website again. I double checked and this change is in the line where it needs to be. I think it’s the same file, but it’s line 63 which appears to be the helper for background:

      background: WebHelpers.format_input_for_html(char.background),
4

WebHelpers was renamed to Website in 0.19. Line 63 in the master branch now reads:

 background: Website.format_input_for_html(char.background),

It seems like perhaps you have a merge conflict that didn’t get resolved entirely.

5

Could be just that particular file as I recall editing it previously due to the error on line 66 back in… I think 0.16.

6

I changed Webhelpers to Website for three lines: 63,64,65 in that same file. Profile editing is back to working.

1 Like