Combats... bug?

AresMUSH
1

I realize this is probably not REALLY a bug, but I did it by accident and this is probably part of why it is suggested that one not destroy characters.

So in a fit of ‘destroy test characters I’m no longer using’, I destroyed one or possibly two characters who were in a combat. Which has made combat glitch out.

For example:

%% Sorry! The code lost its mind while executing a command.  Not your fault.
Please send this error information to the admins and tell them what you were doing at the time:
Description: "combats"
Error: "undefined method `name' for nil:NilClass"

Do you have any suggestions as to how one might fix this?

2

Hmm… that’s annoying. Did you use the destroy command to get rid of them? There’s supposed to be a check in there to prevent that from happening.

You should be able to kill the combat manually. If you know which combat it is, you can just do (if the combat was #123 for example): ruby Combat[123].delete

If you’re not sure, you can get a list of combat IDs by doing ruby Combat.all.map { |c| c.id }.

Let me know if that helps!

1 Like
3

Ahhhh, thank you! That fixed it.

Yes, I did it via destroy. I got a read-out of the character’s setting, but no checks about combat.

4

OK that’s probably a secondary bug then! I’ll take a look. Glad you’re running again though.

ETA: Yeah, looks like the safety guard to stop that has a glitch in it! Will fix in the next patch.

1 Like
5

Unrelated to the actual issue but FYI… The reason that deleting chars is advised against is mostly from a player-confusion angle - having two different characters both named ‘Jack’… are you referring to OldJack or NewJack?

And since things like RP logs are fully integrated with the character profiles, characters will no longer be linked to that log if you delete them. Mails and forum posts will show up as being from “Author Deleted” instead of the original author. Stuff like that.

But nothing bad is supposed to happen code-wise if you destroy characters. (Random bugs such as this one aside.)

6

Makes sense. If I encounter any other weirdness when we do our next batch of deleting things we don’t need anymore, I’ll let you know!

1 Like