Combat Bug

After we killed an NPC, it spammed a warning that the PC’s action was no longer valid. This was in the error log:

2023-04-29 19:26:57 DEBUG - Kynlee has left the combat. 
     

2023-04-29 19:26:56 DEBUG - ATTENTION! Kynlee's action is no longer valid: George is not in this combat. 
     

2023-04-29 19:26:56 DEBUG - Action Reset: Kynlee AresMUSH::FS3Combat::AttackAction George George is not in this combat. 
     

2023-04-29 19:26:55 DEBUG - ATTENTION! Kynlee's action is no longer valid: George is not in this combat. 
     

2023-04-29 19:26:55 DEBUG - Action Reset: Kynlee AresMUSH::FS3Combat::AttackAction George George is not in this combat. 
     

2023-04-29 19:26:54 DEBUG - ATTENTION! Kynlee's action is no longer valid: George is not in this combat. 
     

2023-04-29 19:26:54 DEBUG - Action Reset: Kynlee AresMUSH::FS3Combat::AttackAction George George is not in this combat. 
     

2023-04-29 19:26:49 DEBUG - ATTENTION! Kynlee's action is no longer valid: George is not in this combat. 
     

2023-04-29 19:26:49 DEBUG - Action Reset: Kynlee AresMUSH::FS3Combat::AttackAction George George is not in this combat. 
     

2023-04-29 19:26:38 DEBUG - ATTENTION! Kynlee's action is no longer valid: George is not in this combat. 
     

2023-04-29 19:26:38 DEBUG - Action Reset: Kynlee AresMUSH::FS3Combat::AttackAction George George is not in this combat. 
     

2023-04-29 19:26:34 DEBUG - ATTENTION! Kynlee's action is no longer valid: George is not in this combat. 
     

2023-04-29 19:26:34 DEBUG - Action Reset: Kynlee AresMUSH::FS3Combat::AttackAction George George is not in this combat. 
     

       ^^^^^^^^ ["/home/ares/aresmush/plugins/fs3combat/public/combatant.rb:82:in `action_error?'", "/home/ares/aresmush/plugins/fs3combat/helpers/general_helper.rb:218:in `block (2 levels) in new_turn'", "/home/ares/aresmush/plugins/fs3combat/helpers/general_helper.rb:217:in `each'", "/home/ares/aresmush/plugins/fs3combat/helpers/general_helper.rb:217:in `block in new_turn'", "/home/ares/aresmush/engine/aresmush/commands/dispatcher.rb:71:in `block (2 levels) in spawn'", "/home/ares/aresmush/engine/aresmush/error_block.rb:6:in `with_error_handling'", "/home/ares/aresmush/engine/aresmush/commands/dispatcher.rb:70:in `block in spawn'", "/home/ares/.rvm/gems/ruby-3.1.2/gems/eventmachine-1.2.7/lib/eventmachine.rb:1077:in `block in spawn_threadpool'"] 
     

      a.prepare
     


     

2023-04-29 19:25:48 ERROR - Error in combat turn: undefined method `prepare' for nil:NilClass
     

2023-04-29 19:25:48 DEBUG - Resetting Geoff's action because it's no longer valid. 
     

2023-04-29 19:25:48 DEBUG - ---- Resetting Actions ----

Earlier in the error log…

2023-04-29 19:25:41 DEBUG - AresMUSH::FS3Combat::CombatActionCmd: ID=225 Enactor=Hazel Cmd=combat/attack Geoff=George 
     

       ^^^^^^^^ ["/home/ares/aresmush/plugins/fs3combat/public/combatant.rb:82:in `action_error?'", "/home/ares/aresmush/plugins/fs3combat/helpers/general_helper.rb:218:in `block (2 levels) in new_turn'", "/home/ares/aresmush/plugins/fs3combat/helpers/general_helper.rb:217:in `each'", "/home/ares/aresmush/plugins/fs3combat/helpers/general_helper.rb:217:in `block in new_turn'", "/home/ares/aresmush/engine/aresmush/commands/dispatcher.rb:71:in `block (2 levels) in spawn'", "/home/ares/aresmush/engine/aresmush/error_block.rb:6:in `with_error_handling'", "/home/ares/aresmush/engine/aresmush/commands/dispatcher.rb:70:in `block in spawn'", "/home/ares/.rvm/gems/ruby-3.1.2/gems/eventmachine-1.2.7/lib/eventmachine.rb:1077:in `block in spawn_threadpool'"] 
     

      a.prepare
     


     

2023-04-29 19:24:23 ERROR - Error in combat turn: undefined method `prepare' for nil:NilClass

Seemed to be working fine up until we killed George.

1 Like

Are you maybe on an older version? I thought that was fixed in the latest.

Nope. Installed a week ago on v105.

Yeah there was a hotfix that took out those ATTENTION! Kynlee's action is no longer valid: messages.

I’m not sure that’s related to the problem though.

I think I see the problem. Thanks!

1 Like

Rock. :smiley: I will skip deliberately trying to recreate it in that case. TY! <3