Background skill bug

AresMUSH
1

One of my testers noticed that when you add a BG skill on the web portal, it defaults to ‘interest’, but when you move the points up and down, interest ceases to be an option.

In BG skills config, you can set:

     # Background Skill Ratings
    interest_rating: "Interest"
    proficiency_rating: "Proficiency"
    expertise_rating: "Expertise"

But BG skills seems to be calling an older version of the ratings:

def rating_name
      case rating
      when 0
        return t('fs3skills.everyman_rating')
      when 1
        return t('fs3skills.fair_rating')
      when 2
        return t('fs3skills.good_rating')
      when 3
        return t('fs3skills.exceptional_rating')
      end
    end

I presume that should be everyman_rating, interest_rating, proficiency_rating, and expertise_rating?

2

I think by ‘BG skills config’ you’re referring to the translations file? Those strings aren’t actually used any more, I just apparently forgot to delete them. Background skills are no longer rated Interest/Proficiency/Expertise because the definitions were confusing the heck out of people. They just use Fair/Good/Exceptional the same as action skills.

The web portal code should just say ‘Fair’ instead of ‘Interest’. Will fix - thanks.

3

Ah! Yes, you’re right, it was a translations file and not a config. Thanks for clearing that up.

1 Like