Achievement mark_notices_read Bug

I noticed since the v0.84 release that clicking on an ‘achievement’ notification in the site’s bell notifications list no longer clears the notification, as it should.

I checked the /plugins/profile/web/character_request_handler.rb file, and I noticed that the Login.mark_notices_read(enactor, :achievement) that was originally in the code got deleted when the siteinfo code was put in.

Screenshot:

image

1 Like

Yeah I removed that because it seemed a little weird just to arbitrarily clear the achievement notifications jsut because you looked at your character profile, when you may not have actually looked at the achievements at all.

But I guess in retrospect it’s annoying to have to manually clear them, so… yeah, I can put that back.

1 Like